🌱 KCP: Add current/desired objects to NotUpToDateResult & refactor object creation #12817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
53 tasks
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sbueringer
added
the
area/provider/control-plane-kubeadm
|
/test pull-cluster-api-e2e-main |
sbueringer
changed the title
sbueringer
force-pushed
the
pr-refactor-kcp-desired-state
branch
5 times, most recently
from
9e97a69 to
c8b0bb8
Compare
sbueringer
changed the title
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-refactor-kcp-desired-state
branch
from
c8b0bb8 to
48ab737
Compare
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-refactor-kcp-desired-state
branch
from
48ab737 to
9dab202
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-main |
|
/assign @fabriziopandini /cc @stmcginnis @furkatgofurov7 @alexander-demicev @lentzi90 (if you want to take a look) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #12291